Set reward-size on each trial#131
Open
micahwoodard wants to merge 11 commits into
Open
Conversation
Collaborator
Author
|
@arjunsridhar12345 breaking change here. Reward size changes from task_logic.reward_size.right_valve_volume to trial_outcome.trial.reward_size.right |
bruno-f-cruz
requested changes
Jul 8, 2026
Collaborator
Author
|
@bruno-f-cruz I moved the calculating reward size to quiescent period. Moving to iti required setting it at the beginning of the session as well so made more sense to me to move into quiescent |
This reverts commit e98dbb5.
Collaborator
Author
|
@bruno-f-cruz Task engine now includes pre trial select many which sets reward size for each trial 
|
bruno-f-cruz
requested changes
Jul 13, 2026
Member
There was a problem hiding this comment.
The distinctUntilChanged being inside the SelectMany doesnt really do anything since the sequence only fires once. The solution is to move it to the subject subscriber, ensuring you add it after filtering by side so you dont get false positives at the operator's input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move reward size form task logic level to trial level. Allows to give fraction of reward for auto reward. Closes #85
At bonsai level, default reward is set to 2ul at initialization and during session, reward size is updated in calculate reward block